[Webkit-unassigned] [Bug 132527] AX: [ATK] [PATCH] add text-caret-moved signal to accessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132527





--- Comment #32 from Mario Sanchez Prada <mario at webkit.org>  2014-06-02 03:09:54 PST ---
(In reply to comment #30)
> (In reply to comment #27)
> > Damm... I just found out that I missed two things while reviewing this patch, that caused two tests to get broken:
> > 
> >   accessibility/notification-listeners.html [ Failure ]
> >   accessibility/textarea-selected-text-range.html [ Failure ]
> > [...]
> > The second test is broken because of this:
> > [...]
> > +    if (length)
> > +        return atk_text_set_caret_offset(ATK_TEXT(m_element.get()), 
> [...]
> > It should be "if (!length)" not, "if (length)". I'll propose a quick patch now...
> 
> I did that mistake during style fix. length == 0 would be more readable here (as in 2.00), but such expressions are banned. It's funny that it didn't affect my tests at all.
> 
> My fault, I'm sorry. But please note that I was looking for a way to perform all tests: https://bugs.webkit.org/show_bug.cgi?id=131373#c3

No problem, it's fixed now. Only thing is that we need to remember to ask for merging that follow up patch when asking for integrating this into the stable branch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.