[Webkit-unassigned] [Bug 135399] Web Inspector: 80% of time during recording is spent creating source code locations for profile nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135399





--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org>  2014-07-30 10:50:00 PST ---
(In reply to comment #3)
> (From update of attachment 235732 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235732&action=review
> 
> > Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:281
> > +    _initializeProfileFromPayload: function(payload)
> 
> As much as I hate leaking protocol data past the controllers into the model, I this this is fine for the perf win.

The profileFromPayload could go anywhere (it could go in TimelineManager). It is a standalone factory like method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.