[Webkit-unassigned] [Bug 135168] ASSERT in Document::unregisterCollection reloading apple.com

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135168


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |InRadar
          Component|New Bugs                    |XML DOM




--- Comment #3 from Zan Dobersek <zandobersek at gmail.com>  2014-07-25 08:48:53 PST ---
I think that Document::invalidateNodeListAndCollectionCaches() should be considered as working as intended.

I'd recommend relaxing the assertion in Document::unregisterCollection() instead. It should only check that the HashSet object is empty if the unregister action is coming from invalidateNodeListAndCollectionCaches().

Something like this:
    ASSERT(m_inInvalidateNodeListAndCollectionCaches && !m_listsInvalidatedAtDocument.isEmpty()
        || !m_inInvalidateNodeListAndCollectionCaches);

Opinions?

--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2014-07-29 10:56:38 PST ---
Also: http://alistapart.com/blog/post/ten-css-one-liners-to-replace-native-apps/

<rdar://problem/17778184>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.