[Webkit-unassigned] [Bug 135367] New: Web Inspector: asserts opening inspector - we should not be creating ProbeSetDetailsSections for non-resolved breakpoints

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135367

           Summary: Web Inspector: asserts opening inspector - we should
                    not be creating ProbeSetDetailsSections for
                    non-resolved breakpoints
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org
                CC: timothy at apple.com, joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com,
                    burg at cs.washington.edu, graouts at webkit.org


* SUMMARY
Opening the inspector in local builds I see a lot of asserts trying to make a display string for an non-resolved breakpoint. The Breakpoint's SourceCodeLocation will have a null sourceCode, and produces an assert.

* STEPS TO REPRODUCE
1. Set breakpoints with probes on multiple domains (e.g. bogojoker.com/shell/, nytimes)
2. Load apple.com
3. Open inspector
  => asserts

* DETAILS

console.assert(sourceCode);
[Error] Assertion failed: 
    _locationString (SourceCodeLocation.js, line 294)
    originalLocationString (SourceCodeLocation.js, line 174)
    tooltipString (SourceCodeLocation.js, line 190)
    populateLiveDisplayLocationTooltip (SourceCodeLocation.js, line 243)
    createSourceCodeLocationLink (Main.js, line 1558)
    _probeSetPositionTextOrLink (ProbeSetDetailsSection.js, line 92)
    ProbeSetDetailsSection (ProbeSetDetailsSection.js, line 50)
    _probeSetAdded (ProbeDetailsSidebarPanel.js, line 93)
    dispatch (Object.js, line 141)
    dispatchEventToListeners (Object.js, line 148)
    _probeSetForBreakpoint (ProbeManager.js, line 178)
    (anonymous function) (ProbeManager.js, line 137)
    forEach
    _breakpointActionsChanged (ProbeManager.js, line 129)
    _breakpointAdded (ProbeManager.js, line 98)
    dispatch (Object.js, line 141)
    dispatchEventToListeners (Object.js, line 148)
    addBreakpoint (DebuggerManager.js, line 256)
    restoreBreakpointsSoon (DebuggerManager.js, line 71)
    restoreBreakpointsSoon ([native code], line 0)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.