[Webkit-unassigned] [Bug 135244] Let WheelEvent wrap a PlatformWheelEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135244





--- Comment #21 from Wenson Hsieh <wenson_hsieh at apple.com>  2014-07-28 12:46:31 PST ---
(From update of attachment 235597)
View in context: https://bugs.webkit.org/attachment.cgi?id=235597&action=review

> Source/WebCore/dom/WheelEvent.h:81
>      double deltaX() const { return m_deltaX; } // Positive when scrolling right.

I've tried wrapping these up along with the PlatformWheelEvent, but they ended up breaking LayoutTests/fast/events/wheelevent-constructor.html, since double precision is required (the diff ended up looking like 20.3 vs. 20.29999...).

> Source/WebCore/dom/WheelEvent.h:87
>      unsigned deltaMode() const { return m_deltaMode; }

m_deltaMode could also be removed from WheelEvent, but doing so would mean that we need to compute the deltaMode on the fly using PlatformWheelEvent.granularity() every time deltaMode() is called. I chose not to take this option and store the result in m_deltaMode instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.