[Webkit-unassigned] [Bug 135288] New: [GTK] CMake tries to install JavaScriptCore-3.0.gir outside of install prefix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135288

           Summary: [GTK] CMake tries to install JavaScriptCore-3.0.gir
                    outside of install prefix
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mcatanzaro at gnome.org
                CC: mrobinson at webkit.org



Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235520|                            |review?, commit-queue?
               Flag|                            |


I'm trying to install WebKit into an install prefix in my home directory, calling CMake manually rather than with the build-webkit script:

cmake /home/mcatanzaro/WebKit -DPORT=GTK -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/mcatanzaro/jhbuild/install -DLIB_INSTALL_DIR=/home/mcatanzaro/jhbuild/install/lib -GNinja

But CMAKE_INSTALL_PREFIX is not respected when installing JavaScriptCore-3.0.gir; it's unconditionally installed into /usr/share because FindGObjectIntrospection.cmake uses pkgconfig to decide where to install to, and that's what pkgconfig says to do:

# /usr/lib64/pkgconfig/gobject-introspection-1.0.pc
datadir=/usr/share
...
girdir=${datadir}/gir-1.0

FindGObjectIntrospection.cmake tries to define the prefix variable, but it's not actually used by gobject-introspection-1.0.pc since $datadir was set to /usr/share by my distro (Fedora) at configure time (I think all RPM-based distros will do this). So this can never work.

The upcoming patch fixes this error from the user's perspective, but makes FindGObjectIntrospection.cmake depend on variables set in OptionsGTK.cmake, which I'm worried is probably evil. I don't know what else to do, though.

--- Comment #1 from Michael Catanzaro <mcatanzaro at gnome.org>  2014-07-25 08:29:28 PST ---
Created an attachment (id=235520)
 --> (https://bugs.webkit.org/attachment.cgi?id=235520&action=review)
Patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.