[Webkit-unassigned] [Bug 135215] Turn x/y to presentation attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135215


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235444|review?                     |review+
               Flag|                            |




--- Comment #2 from Dean Jackson <dino at apple.com>  2014-07-24 15:15:54 PST ---
(From update of attachment 235444)
View in context: https://bugs.webkit.org/attachment.cgi?id=235444&action=review

> LayoutTests/svg/css/parse-length-expected.txt:7
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute width="  100"
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute width="100   "
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute x="  100"
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute x="100   "
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute y="  100"
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute y="100   "

Why are these invalid?

> LayoutTests/svg/css/parse-length.html:12
> +description("Test that 'with' presentation attribute is parsed with CSS presentation rules.");

width not with

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2902
> +        // New positioning and sizing properties for SVG

Nit: missing .

> Source/WebCore/rendering/style/SVGRenderStyleDefs.h:294
> +    // Positioning and sizing properties.
> +    class StyleLayoutData : public RefCounted<StyleLayoutData> {

It's just positioning.

> Source/WebCore/svg/SVGAnimateElement.cpp:6
> + * Copyright (C) 2014 Adobe Systems Incorporated. All rights reserved.

There were no other changes in this file.

> Source/WebCore/svg/SVGFilterElement.cpp:7
> + * Copyright (C) 2014 Adobe Systems Incorporated. All rights reserved.

Or this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.