[Webkit-unassigned] [Bug 135229] [Cocoa] WebCore::=?UTF-8?Q?ProtectionSpace=20doesn=E2=80=99t=20preserve=20all=20NSURLProtectionSpace=20properties?=, such as the distinguishedNames array

Thu Jul 24 14:53:14 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=135229

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235450|review?                     |review+
               Flag|                            |

--- Comment #18 from Alexey Proskuryakov <ap at webkit.org>  2014-07-24 14:53:26 PST ---
(From update of attachment 235450)
View in context: https://bugs.webkit.org/attachment.cgi?id=235450&action=review

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:1
> -ï»¿<?xml version="1.0" encoding="utf-8"?>
> +<?xml version="1.0" encoding="utf-8"?>

:-/

> Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:29
> +#include "ProtectionSpaceBase.h"

Please add an #if/#error somewhere here to indicate that this is a Windows only file.

> Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:58
> +    bool encodingRequiresPlatformData() const { return m_nsSpace && !encodingRequiresPlatformData(m_nsSpace.get()); }

!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.