[Webkit-unassigned] [Bug 135143] JSLock release should only modify the AtomicStringTable if it modified in acquire

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135143


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235376|commit-queue+               |
               Flag|                            |




--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org>  2014-07-23 15:56:01 PST ---
(In reply to comment #9)
> (From update of attachment 235376 [details])
> What if we set the table on entry, and it was null on entry? How will it get back to null?

Good point. My understanding is that the WTFThreadData's AtomicStringTable can (and should) never be null. I could ASSERT that now, and perhaps ultimately we could move to references. Alternatively we could have a bool alongside the pointer.

--- Comment #11 from Geoffrey Garen <ggaren at apple.com>  2014-07-24 10:06:53 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 235376 [details] [details])
> > What if we set the table on entry, and it was null on entry? How will it get back to null?
> 
> Good point. My understanding is that the WTFThreadData's AtomicStringTable can (and should) never be null. I could ASSERT that now, and perhaps ultimately we could move to references. Alternatively we could have a bool alongside the pointer.

It looks like WTFThreadData always sets a default table, so I think you're right. Let's ASSERT.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.