[Webkit-unassigned] [Bug 135233] New: Member name collision in RenderView and SelectionSubtreeRoot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135233

           Summary: Member name collision in RenderView and
                    SelectionSubtreeRoot
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: stavila at adobe.com
                CC: hyatt at apple.com, mihnea at adobe.com, rniwa at webkit.org,
                    rego at igalia.com, jfernandez at igalia.com


SelectionSubtreeRoot members:

    RenderObject* m_selectionStart;
    int m_selectionStartPos;
    RenderObject* m_selectionEnd;
    int m_selectionEndPos;


RenderView members:

    RenderObject* m_selectionStart;
    RenderObject* m_selectionEnd;
    int m_selectionStartPos;
    int m_selectionEndPos;


Because RenderView inherits SelectionSubtreeRoot, this presents a problem. Furthermore, the getter/setter methods also have identical names (selectionStart(), setSelectionStart(...) etc). 

Example: in RenderView.cpp, setting the start/end selection members to some values. Then calling selectionStartEndPositions(...) which retrieves those values. Because this method is inside SelectionSubtreeRoot, it will return the version of the selection members from SelectionSubtreeRoot, not the ones you would normally expect it to. This has great potential for creating confusion and hard-to-track issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.