[Webkit-unassigned] [Bug 135229] [Cocoa] WebCore::=?UTF-8?Q?ProtectionSpace=20doesn=E2=80=99t=20preserve=20all=20NSURLProtectionSpace=20properties?=, such as the distinguishedNames array

Thu Jul 24 00:04:13 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=135229

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org

--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org>  2014-07-24 00:04:27 PST ---
Attachment 235408 did not pass style-queue:

ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:57:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:74:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:81:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:79:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:81:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:101:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:102:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:102:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:103:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:39:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:45:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61:  Wrong number of spaces before statement. (expected: 53)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:32:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:40:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:41:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:42:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:43:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:179:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 29 in 24 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.