[Webkit-unassigned] [Bug 135211] ScriptController::updateDocument ASSERT mutating map while iterating map

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135211


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235386|commit-queue?               |commit-queue-
               Flag|                            |
                 CC|                            |sam at webkit.org

Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235386|review?                     |review+
               Flag|                            |

Build Bot <buildbot at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |buildbot at hotmail.com,
                   |                            |rniwa at webkit.org




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2014-07-23 15:45:56 PST ---
(From update of attachment 235386)
View in context: https://bugs.webkit.org/attachment.cgi?id=235386&action=review

> Source/WebCore/ChangeLog:10
> +        Avoid iterating over m_windowShells in more places. This prevents
> +        the possibility of a collection during JSC allocation which might
> +        cause a mutation to m_windowShells (HTMLMediaElement destruction).

This is phrased poorly. It doesn't prevent the possibility of a collection. It avoids the mutation of m_windowShells during iteration. I'll rewrite it.

--- Comment #6 from Oliver Hunt <oliver at apple.com>  2014-07-23 16:03:26 PST ---
(From update of attachment 235386)
View in context: https://bugs.webkit.org/attachment.cgi?id=235386&action=review

> Source/WebCore/bindings/js/ScriptController.cpp:177
> +    return windowShells;

will this get happy move semantics?

--- Comment #7 from Oliver Hunt <oliver at apple.com>  2014-07-23 16:03:43 PST ---
(From update of attachment 235386)
View in context: https://bugs.webkit.org/attachment.cgi?id=235386&action=review

>> Source/WebCore/bindings/js/ScriptController.cpp:177
>> +    return windowShells;
> 
> will this get happy move semantics?

will this get happy move semantics?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.