[Webkit-unassigned] [Bug 135206] [iOS] Client-certificate authentication isn’t working with some certificates

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135206





--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2014-07-23 12:38:10 PST ---
(From update of attachment 235368)
View in context: https://bugs.webkit.org/attachment.cgi?id=235368&action=review

> Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:632
> +static CFDataRef copyPersistentRef(SecKeyRef key)

This doesn't seem to be in a PLATFORM(IOS) ifdef, and it should.

> Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:637
> +    RetainPtr<NSDictionary> query = @{

I don't see how this RetainPtr can be appropriate here.

> Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:645
> +    OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query.get(), &persistentRef);

Do we need __bridge in WebKit code?

> Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:652
> +    if (CFGetTypeID(persistentRef) != CFDataGetTypeID()) {
> +        CFRelease(persistentRef);
> +        return nullptr;
> +    }

Can this happen? Documentation says that kSecReturnPersistentRef always provides a CFDataRef.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.