[Webkit-unassigned] [Bug 135143] JSLock release should only modify the AtomicStringTable if it modified in acquire

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 23 11:07:58 PDT 2014


--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org>  2014-07-23 11:08:11 PST ---
(In reply to comment #6)
> Stealing ap's message from the wrong bug:
> "This change broke three API tests, so I'm going to roll out.
> Tests that failed:
>   WKUserContentController.ScriptMessageHandlerWithNavigation
>   WebKit2.RestoreSessionStateContainingFormData
> Tests that timed out:
>   DeviceScaleFactorOnBack.WebKit2"

I can reproduce.

Thinking about things, now we might incorrectly balance in the opposite way after this change.

We need to handle what will happen if:
  - we acquire the lock with a vm (set the atomic string table)
  - m_vm gets cleared
  - we release the lock without a vm
    => we need to restore the atomic string table.

Making the appropriate changes the tests all pass. I need to test the original case and then I'll put up another patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list