[Webkit-unassigned] [Bug 134860] Make improvements to Type Profiling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134860


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235326|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Filip Pizlo <fpizlo at apple.com>  2014-07-22 17:57:45 PST ---
(From update of attachment 235326)
View in context: https://bugs.webkit.org/attachment.cgi?id=235326&action=review

It's good modulo two small changes.  Can you file that bug, fix that indentation, and upload a new patch so that I can land it?

> Source/JavaScriptCore/runtime/HighFidelityTypeProfiler.cpp:40
> +    TypeProfilerSearchDescriptor descriptor = location->m_globalVariableID == HighFidelityReturnStatement ? TypeProfilerSearchDescriptorFunctionReturn
> +                                              : location->m_globalVariableID == HighFidelityThisStatement ? TypeProfilerSearchDescriptorThisStatement
> +                                              : TypeProfilerSearchDescriptorNormal;

I think that you should fix the style here.  In WebKit, any line that is a continuation of the statement on the previous line should be indented just an extra four spaces.

> Source/JavaScriptCore/runtime/HighFidelityTypeProfiler.cpp:131
> +    // FIXME: BestMatch should never be null past this point. This doesn't hold currently because we ignore some Eval/With/VarInjection variable assignments.

Can has bugzilla bug for this FIXME?  I think that every FIXME should have a bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.