[Webkit-unassigned] [Bug 135143] JSLock release should only modify the AtomicStringTable if it modified in acquire

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 22 10:25:00 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=135143


Pratik Solanki <psolanki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235264|review?                     |review+
               Flag|                            |




--- Comment #3 from Pratik Solanki <psolanki at apple.com>  2014-07-22 10:25:14 PST ---
(From update of attachment 235264)
View in context: https://bugs.webkit.org/attachment.cgi?id=235264&action=review

Patch looks fine to me but would be good if Geoff took a look as well.

> Source/JavaScriptCore/runtime/JSLock.cpp:170
> +    if (m_vm) {

Early return?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list