[Webkit-unassigned] [Bug 135046] Turn width/height to presentation attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135046


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235181|review?                     |review+
               Flag|                            |




--- Comment #14 from Dean Jackson <dino at apple.com>  2014-07-21 15:54:30 PST ---
(From update of attachment 235181)
View in context: https://bugs.webkit.org/attachment.cgi?id=235181&action=review

> Source/WebCore/svg/SVGElement.cpp:544
> +    auto svgIt = cssPropertyWithSVGDOMMap.find(attributeName.impl());
> +    if (svgIt != cssPropertyWithSVGDOMMap.end())

Nit: I think if you use auto you should probably call the variable svgIterator, or svgPropertyIterator or something.

> Source/WebCore/svg/SVGElement.h:104
> +        // Trigger style recalculation for "elements as resource" (e.g. referenced by feImage).
> +        setNeedsStyleRecalc(InlineStyleChange);

Is this going to be a big performance hit?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.