[Webkit-unassigned] [Bug 135098] Web Inspector: Add esprima to the WebInspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135098


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235238|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2014-07-21 13:37:07 PST ---
(From update of attachment 235238)
View in context: https://bugs.webkit.org/attachment.cgi?id=235238&action=review

> Source/WebInspectorUI/UserInterface/External/Esprima/esprima.js:35
> +// I delted the code that determines the context esprima is loaded in (node.js, the browser, etc.) and replaced it with WebInspector._esprima.

We should not have "I" in a comment. Someone reading this will not know who that refers too, and any one individual does not necessary own a file. This is more of a "we" meaning the project / contributors as a whole.

Something like this would be sufficient:

  // WebKit Modifications:
  //   - replaced code that automatically determines Esprima execution context (node, browser, etc.) with WebInspector._esprima

The idea here is to make it easier for the next person who updates Esprima by documenting the changes we've made.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.