[Webkit-unassigned] [Bug 135098] Web Inspector: Add esprima to the WebInspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135098


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235176|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org>  2014-07-21 10:58:42 PST ---
(From update of attachment 235176)
View in context: https://bugs.webkit.org/attachment.cgi?id=235176&action=review

> Source/WebInspectorUI/ChangeLog:11
> +        * UserInterface/External/esprima.js: Added.

Lets make a subfolder for this, like other External libraries.

    UserInterface/External/Esprima/esprima.js

> Source/WebInspectorUI/UserInterface/External/esprima.js:1
> +/*

We will want to minify this script in production builds. See how this script handles CodeMirror:

    Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl

This could be done in a follow-up.

> Source/WebInspectorUI/UserInterface/External/esprima.js:34
> +WebInspector._esprima = {};

You should mention the edits you've made in a comment in this file. I suspect this, and its use below, are the only changes you made.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.