[Webkit-unassigned] [Bug 135049] Division by zero in fast-dtoa.cc.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135049


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235127|review?                     |review-
               Flag|                            |




--- Comment #5 from Benjamin Poulain <benjamin at webkit.org>  2014-07-20 23:47:09 PST ---
(From update of attachment 235127)
First, I agree with Darin: this must have a test.

But even with the test, I do not believe this would be the right fix. If divisor is zero, that likely means the input is invalid. If that happen, we should handle that earlier in the stack (or maybe an early return in DigitGen()). I don't think you can just ignore this loop.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.