[Webkit-unassigned] [Bug 131172] Mouse Cursor doesn't change appropriately.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131172





--- Comment #17 from Darin Adler <darin at apple.com>  2014-07-20 08:57:43 PST ---
(From update of attachment 234930)
View in context: https://bugs.webkit.org/attachment.cgi?id=234930&action=review

Can’t review because the patch doesn’t explain itself sufficiently in comments or in change log.

> Source/WebCore/rendering/RenderLayer.cpp:4547
> +        if (!request.isChildFrameHitTest() && (request.active() || request.release() || (request.move() && renderer().frame().isMainFrame())) && isRootLayer()) {

I don’t understand how this change relates to the change log comment.

This says that the main frame is a special case, and that the “move” flag is relevant. Nothing in the change log helps explain why that’s correct to consider.

My guess is that for subframes we’d like to fall back to the main frame and that’s why the isMainFrame test is relevant, but I’m not sure that’s the reason. And I have no idea why checking the move() boolean is relevant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.