[Webkit-unassigned] [Bug 135057] Add 'analyze' target to the Makefiles

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 18 15:26:25 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=135057


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235150|review?                     |review+
               Flag|                            |




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2014-07-18 15:26:40 PST ---
(From update of attachment 235150)
View in context: https://bugs.webkit.org/attachment.cgi?id=235150&action=review

r=me

> Makefile.shared:28
>  
> +

Unintentional blank lined added?

> Makefile.shared:41
> +analyze:
> +	$(SCRIPTS_PATH)/set-webkit-configuration --release

It would be nice if we could support analyze with --debug builds as well. Maybe add a STYLE=debug argument to the make command such that unset STYLE defaults to 'release', but lets you override to 'debug'.

This can be added later, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list