[Webkit-unassigned] [Bug 135031] Fixed position elements are misplaced when a WK1 view has contentInsets set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135031





--- Comment #3 from Beth Dakin <bdakin at apple.com>  2014-07-17 16:08:01 PST ---
(In reply to comment #2)
> (From update of attachment 235098 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235098&action=review
> 
> > Source/WebCore/platform/mac/ScrollViewMac.mm:127
> > +        IntSize frameSize = IntSize([scrollView() frame].size);
> 
> No need for the " = IntSize"
> 

Fixed.

> > Source/WebCore/platform/mac/ScrollViewMac.mm:135
> >      END_BLOCK_OBJC_EXCEPTIONS;
> 
> does this need to be before return? I think it might, but I am not sure
> 
> > Source/WebCore/platform/mac/ScrollViewMac.mm:137
> >      return IntRect();
> 
> why is this still here?

Both of these have the same answer: this is what the function previously did. It had the normal return statement just before END_BLOCK_OBJC_EXCEPTIONS, and then a generic return after. Other functions in ScrollViewMac that return things follow this convention as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.