[Webkit-unassigned] [Bug 134301] Implement parsing for CSS scroll snap points

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134301


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234998|review?                     |review-
               Flag|                            |




--- Comment #37 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-07-17 12:21:35 PST ---
(From update of attachment 234998)
View in context: https://bugs.webkit.org/attachment.cgi?id=234998&action=review

> Source/WebCore/rendering/style/StyleScrollSnapPoints.h:58
> +    static Length defaultRepeatPoint()
> +    {
> +        return Length(100, Percent);
> +    }
> +    
> +    static Length defaultDestinationPoint()
> +    {
> +        return Length(0, Fixed);
> +    }

Not sure I like the names having "point" since these don't use IntPoint/FloatPoint.

> LayoutTests/platform/mac/css3/scroll-snap/scroll-snap-property-computed-style-expected.txt:98
> +pixel/pixel destination : 10px 50px
> +PASS window.getComputedStyle(document.body).getPropertyValue('-webkit-scroll-snap-destination') is '10px 50px'

You should test fractional values here as well (10.5px, 12.234px)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.