[Webkit-unassigned] [Bug 134970] ASSERTION FAILED: listNode in WebCore::RenderListItem::updateListMarkerNumbers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134970


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235064|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2014-07-17 09:30:40 PST ---
(From update of attachment 235064)
View in context: https://bugs.webkit.org/attachment.cgi?id=235064&action=review

> Source/WebCore/rendering/RenderListItem.cpp:113
> +    if (!firstNode)
> +        firstNode = &listItem->element();

This fix is not right. I don’t think the element itself should be returned as the list. The enclosingList function should not return something that would return false from isList.

This function is allowed to return null if there is no enclosing list. The fix should be at the call sites, not here in this function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.