[Webkit-unassigned] [Bug 134990] Need FTL implementation of SkipTopScope

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134990


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235021|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Geoffrey Garen <ggaren at apple.com>  2014-07-16 14:37:45 PST ---
(From update of attachment 235021)
View in context: https://bugs.webkit.org/attachment.cgi?id=235021&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3421
> +            m_out.isZero64( m_out.load64(addressFor(machineActivationRegister)))

No space after the paren here.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3423
> +            , unsure(isNull)
> +            , unsure(notNull));

These two can probably go on the same line.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3431
> +        setJSValue(m_out.phi(m_out.intPtr, top,next));

Space after "top".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.