[Webkit-unassigned] [Bug 134958] New: Adding myself to contributors.json breaks a webkitpy test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 15 18:54:46 PDT 2014


           Summary: Adding myself to contributors.json breaks a webkitpy
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: clopez at igalia.com

I was adding myself to Tools/Scripts/webkitpy/common/config/contributors.json after I was accepted as commiter.

However, doing it breaks a test of webkitpy due to usage of the very common spanish surname "lopez" as whois query for the IRC bot tests.

$ Tools/Scripts/test-webkitpy
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

Checking imports .../home/clopez/webkit/webkit
[809/1424] webkitpy.tool.bot.irc_command_unittest.IRCCommandTest.test_whois failed:                                                             
  Traceback (most recent call last):
    File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py", line 56, in test_whois
      whois.execute("tom", ["lopez"], None, None))
  AssertionError: 'tom: lopez is "Xan Lopez" <xan.lopez at gmail.com> (:xan) (r). Why do you ask?' != u'tom: I\'m not sure who you mean?  "Carlos Alberto Lopez Perez" <clopez at igalia.com> (:clopez) (c) or "Xan Lopez" <xan.lopez at gmail.com> (:xan) (r) could be \'lopez\'.'

Ran 1424 tests in 3.843s                                                                              
FAILED (failures=1, errors=0)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list