[Webkit-unassigned] [Bug 133796] ASSERT_NOT_REACHED() in WebCore::fontWeightIsBold

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133796


Tibor Mészáros <tmeszaros.u-szeged at partner.samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232953|0                           |1
        is obsolete|                            |
 Attachment #232953|review?                     |
               Flag|                            |
 Attachment #234912|                            |review?, commit-queue?
               Flag|                            |




--- Comment #10 from Tibor Mészáros <tmeszaros.u-szeged at partner.samsung.com>  2014-07-15 04:09:24 PST ---
Created an attachment (id=234912)
 --> (https://bugs.webkit.org/attachment.cgi?id=234912&action=review)
Patch v2

    Source/WebCore/editing/EditingStyle.cpp:1516
    static bool fontWeightIsBold(CSSValue* fontWeight)

Is now CSSValue&.

    Source/WebCore/editing/EditingStyle.cpp:1551
    +static bool fontWeightNeedsResolving(CSSValue* fontWeight)

Is now CSSValue&.

    Source/WebCore/editing/EditingStyle.cpp:1574
    + if (RefPtr<CSSValue> baseFontWeight = extractPropertyValue(baseStyle, CSSPropertyFontWeight)) {
    + if (RefPtr<CSSValue> fontWeight = mutableStyle->getPropertyCSSValue(CSSPropertyFontWeight)) {
    + if (!fontWeightNeedsResolving(fontWeight.get()) && (fontWeightIsBold(fontWeight.get()) fontWeightIsBold(baseFontWeight.get())))

Merged the upper three "If" into one

    Source/WebCore/editing/EditingStyle.cpp:1556
    + return !(value CSSValueLighter || value == CSSValueBolder);

I had put CSSValueLighter and CSSValueBolder into fontWeightIsBold. It will be correct in the case where lighter still results in bolded text or bolder resulting in "light" text.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.