[Webkit-unassigned] [Bug 134721] Move dir attribute from HTMLDocument to Document to match the spec

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134721





--- Comment #8 from Daniel Bates <dbates at webkit.org>  2014-07-14 10:09:56 PST ---
(From update of attachment 234615)
View in context: https://bugs.webkit.org/attachment.cgi?id=234615&action=review

>> Source/WebCore/bindings/objc/PublicDOMInterfaces.h:112
>>  - (DOMElement *)createElement:(NSString *)tagName;
> 
> This attribute is certainly not available in OS X 10.5. r- because of this.

Yes, this is a bit disingenuous as it documents that this API was available on the base class since OS X 10.5. What is the preferred way is to resolve this issue? I mean, we're moving an API that was made available in OS X 10.5 from a derived class to a base class. I guess you could move this property to the base class mark it as available in a later release and then add a custom setter and getter for dir in DOMHTMLDocument with the WEBKIT_AVAILABLE_MAC(10_5) decoration that forwards to the corresponding setter and getter for the base class property :\

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.