[Webkit-unassigned] [Bug 134832] [GTK] Simplify make-dist command line arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134832


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234762|review?                     |review+
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2014-07-13 11:46:46 PST ---
(From update of attachment 234762)
View in context: https://bugs.webkit.org/attachment.cgi?id=234762&action=review

Looks good, but consider moving the code that calculate the current version.

> Tools/gtk/make-dist.py:303
> +            pkgconfig_file = os.path.join(arguments.build_dir, "Source/WebKit2/webkit2gtk-3.0.pc")
> +            if os.path.isfile(pkgconfig_file):
> +                p = subprocess.Popen(['pkg-config', '--modversion', pkgconfig_file], stdout=subprocess.PIPE)
> +                version = p.communicate()[0]
> +                if version:
> +                    tarball_root += '-' + version.rstrip('\n')

Would it make sense to move to this after argument parsing so that other parts of the code can use arguments.version safely in the future?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.