[Webkit-unassigned] [Bug 134722] Support radial-gradients with relative offsets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134722





--- Comment #6 from Martin Hodovan <mhodovan.u-szeged at partner.samsung.com>  2014-07-10 02:00:42 PST ---
(In reply to comment #2)
> (From update of attachment 234558 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234558&action=review
> 
> There shouldn't be any reason to convert this from a reference to a pointer.

I converted the 'value' reference to a pointer because Pair::second() returns with a pointer,
and references are not reseatable. Why is it important to keep 'value' a reference?
I had to add a local pointer variable this way, which is confusing and could be evitable.
However, seems like the value of this reference is not used outside this function, so it won't
cause further problems.

(In reply to comment #3)
> (From update of attachment 234558 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234558&action=review
> 
> Any particular reason to truncate size.width/height to integral value? both origin and edgeDistance should be float.

Thanks, I changed them both to float. (Truncating edgeDistance wasn't part of my patch, though.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.