[Webkit-unassigned] [Bug 134759] [EFL][WK2] Add new Public API in ewk_download_job.h to get length of the data already downloaded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134759


Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234628|review?                     |review+
               Flag|                            |




--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-07-09 05:33:26 PST ---
(From update of attachment 234628)
View in context: https://bugs.webkit.org/attachment.cgi?id=234628&action=review

LGTM except for minor nits.

> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:189
> + * @param download a #Ewk_Download_Job to query.

We haven't add period at @param and @return.

> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:191
> + * @return the length of the data already downloaded.

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:193
> +EAPI uint64_t ewk_download_job_received_data_length_get(const Ewk_Download_Job *download);

Isn't "data_size" more proper for this API ?

> Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h:71
> +    uint64_t receivedData() const;

receivedDataSize() ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.