[Webkit-unassigned] [Bug 134759] [EFL][WK2] Add new Public API in ewk_download_job.h to get length of the data already downloaded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 9 04:41:19 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=134759


Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234627|review?                     |review-
               Flag|                            |




--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-07-09 04:41:34 PST ---
(From update of attachment 234627)
View in context: https://bugs.webkit.org/attachment.cgi?id=234627&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:193
> +EAPI uint64_t ewk_download_get_received_data_length(const Ewk_Download_Job *download);

Missing API test for this new API.

And also, looks wrong API naming. Generally verb is placed at the end of function name in EFL function.

For example,
ewk_download_received_data_length_get()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list