[Webkit-unassigned] [Bug 134727] [GTK] Gstreamer missing from the install-dependencies script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134727





--- Comment #10 from Mario Sanchez Prada <mario at webkit.org>  2014-07-09 02:36:10 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > GStreamer is built inside the internal JHBuild. The install-dependencies script is not meant to replace the internal JHBuild setup. Please revert this change.
> 
> I have to agree here.

I disagree, though. JHBuild is a helper tool that enable people to build WebKit when system packages are not recent enough, as well as to help "normalize" testing environments such as the ones used in the bots.

However, I don't see what's the point of having to build all the deps if your distro have recent enough versions of those packages (e.g. Ubuntu 14.04 at this time), but in order to do that the developer would need to install these 2 gstreamer devel packages first, as they are core deps of WebKit.

On top of that, I don't see any collision between having these 2 packages in the apt-get section of the install-dependencies script (as it's done already for the yum section, btw) and building gstreamer anyway in the jhbuild moduleset:

 - If you execute both install-dependencies and update-webkitgtklibs, WebKit will pick the versions from the jhbuild, as they likely are newer. No conflict here.

 - If you don't execute update-webkitgtklibs, then WebKit will use the (recent enough) versions in your system, saving you time.

In both cases it's a Win-Win situation, while keeping these 2 packages out of the install-dependencies script means only the first scenario will work.

Last, I was pointed to http://trac.webkit.org/wiki/BuildingGtk as proof that both steps should be executed, but I think that's a mistake too, as you can certainly build and run WebKitGTK if the system is new enough without using the jhbuild at all.

So, could you please ellaborate a bit more in how exactly including those _core_ deps in install-dependencies is a bad thing? So far I can't see any good reason, to be honest

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.