[Webkit-unassigned] [Bug 134597] Convert fast/css/text-overflow-ellipsis* layout tests to reftests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134597


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234560|0                           |1
        is obsolete|                            |
 Attachment #234560|review?                     |
               Flag|                            |
 Attachment #234563|                            |review?
               Flag|                            |




--- Comment #5 from Mario Sanchez Prada <mario at webkit.org>  2014-07-08 08:39:49 PST ---
Created an attachment (id=234563)
 --> (https://bugs.webkit.org/attachment.cgi?id=234563&action=review)
Path proposal

(In reply to comment #2)
> (From update of attachment 234560 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234560&action=review
> 
> > LayoutTests/fast/css/text-overflow-ellipsis-expected.html:18
> > +.forcertl {
> > +    direction: rtl;
> > +    unicode-bidi: bidi-override;
> > +}
> 
> I don't think we should be relying on UBA in the expected result for this test given where ellipses will be drawn will be affected by UBA itself.
> Reorder the content manually instead.
> 
Good point. Attaching now a new patch following that suggestion.

> > LayoutTests/fast/css/text-overflow-ellipsis-strict-expected.html:18
> > +    direction: rtl;
> > +    unicode-bidi: bidi-override;
> 
> Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.