[Webkit-unassigned] [Bug 134724] fast/css/vertical-text-overflow-ellipsis* provide the wrong expectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134724





--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2014-07-08 08:04:06 PST ---
(In reply to comment #1)
> (In reply to comment #0)
> > PS: Perhaps we should remove all those text expectations that are wrong anyway and add [ Failure ] entries in the TestExpectations file, to keep track of the issue as well in that way
> 
> That would be worse. With the wrong expectation checked in, we would know when the output changes, adding a test expectation [Failure] would only mask any future changes to the test output.

What if we remove those wrong expectations and convert the original tests to reftests (so the -expected.html file expects the right thing, hardcoding the ellipsis character) and then add the [ Failure ] expectation?

That way, when the problem is fixed the output of the .html and the -expected.html should match and that should be noticed while running the layout tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.