[Webkit-unassigned] [Bug 132602] [GTK] [Stable] Can't browse new Google maps with latest stable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132602





--- Comment #7 from Sergio Villar Senin <svillar at igalia.com>  2014-07-07 01:58:55 PST ---
(From update of attachment 234403)
View in context: https://bugs.webkit.org/attachment.cgi?id=234403&action=review

Overall the patch looks good but I disagree on removing only the "Version" part. See bellow.

> Source/WebCore/platform/gtk/UserAgentGtk.cpp:253
> +    uaString.appendLiteral(" Safari/");

I wouldn't do this. As I mentioned in the change that added the "Version" part, there is no point on having "Safari/" without the "Version" string as that's invalid. So either we add them both or we add nothing.

That'd mean that we should likely rename the quirk to something like ClaimToBeSafari or something.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.