[Webkit-unassigned] [Bug 134674] [EFL][WK2] Add a "focus, control, handover" signal.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134674





--- Comment #2 from Ryuan Choi <ryuan.choi at samsung.com>  2014-07-06 21:56:56 PST ---
(From update of attachment 234477)
View in context: https://bugs.webkit.org/attachment.cgi?id=234477&action=review

> Source/WebKit2/ChangeLog:9
> +        Add a "focus,control,handover" signal to handover its focus control because there are no elements 
> +        of webview to focus on the given direction.

Can we test this?

> Source/WebKit2/UIProcess/efl/PageUIClientEfl.cpp:103
> +    Ewk_Focus_Direction direction = static_cast<Ewk_Focus_Direction>(wkDirection);

Nowadays, we didn't just cast WK enum to ewk enum.
Please use switch or if statement.

> Source/WebKit2/UIProcess/efl/PageUIClientEfl.cpp:104
> +    toPageUIClientEfl(clientInfo)->m_view->smartCallback<FocusControlHandover>().call(&direction);

Why & ?
You just have to pass direction.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.