[Webkit-unassigned] [Bug 134551] [GTK] Move user style sheet API out of WebKitWebViewGroup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134551





--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-07-04 01:07:58 PST ---
(From update of attachment 234361)
View in context: https://bugs.webkit.org/attachment.cgi?id=234361&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp:80
> +            String::fromUTF8(source), URL { },

Are you sure we don't need the baseURL?

> Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:33
> +        : userContentController(WebUserContentControllerProxy::create()) { }

Move the {} the their own line, please

    _WebKitUserContentManagerPrivate()
        : userContentController(WebUserContentControllerProxy::create())
    {
    }

> Source/WebKit2/UIProcess/API/gtk/WebKitUserContentPrivate.h:24
> +

Remove this empty line

> Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.cpp:103
> +    m_userStyleSheets.append(std::move(userStyleSheet));

Use WTF::move() instead of std::move()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.