[Webkit-unassigned] [Bug 134486] [EFL][WK2] Minibrowser: Enhance the application to show text search count

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134486


Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234326|review?                     |review+
               Flag|                            |




--- Comment #14 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-07-03 20:35:14 PST ---
(From update of attachment 234326)
View in context: https://bugs.webkit.org/attachment.cgi?id=234326&action=review

LGTM except for nits.

> Tools/MiniBrowser/efl/main.c:1700
> +    const int *matchCount = (const int *)(event_info);

matchCount is not efl style. match_count ?

> Tools/MiniBrowser/efl/main.c:1963
> +    evas_object_smart_callback_add(window->ewk_view, "text,found", on_search_text_found, window);

Personally I prefer to place it alphabetically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.