[Webkit-unassigned] [Bug 133395] Web Inspector: debugger should be able to show variable types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 3 11:14:19 PDT 2014


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
 Attachment #234237|review?, commit-queue?      |review+
               Flag|                            |

--- Comment #30 from Filip Pizlo <fpizlo at apple.com>  2014-07-03 11:14:37 PST ---
(From update of attachment 234237)
View in context: https://bugs.webkit.org/attachment.cgi?id=234237&action=review

R=me, but can you post a new patch to a different bug, and also fix the one indentation issue?

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:584
> +        public:

You don't need this.  Struct members are public by default.  Also, ordinarily this wouldn't be indented.  Example:

class Foo {
    int m_bar;

Notice how "public:" aligns with "class".

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:586
> +            unsigned m_startDivot;
> +            unsigned m_endDivot;

Deindent by four spaces.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list