[Webkit-unassigned] [Bug 134486] [EFL][WK2] Minibrowser: Enhance the application to show text search count

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134486


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234319|commit-queue-               |commit-queue?
               Flag|                            |




--- Comment #10 from Ryuan Choi <ryuan.choi at samsung.com>  2014-07-03 00:25:46 PST ---
(From update of attachment 234319)
View in context: https://bugs.webkit.org/attachment.cgi?id=234319&action=review

> Tools/MiniBrowser/efl/main.c:1703
> +    evas_object_focus_set(window->ewk_view, EINA_FALSE);
> +    elm_object_focus_set(window->search.search_field_count, EINA_TRUE);

Can I know why you touch the focus (and repeatedly)?

> Tools/MiniBrowser/efl/main.c:1715
> +    evas_object_focus_set(window->ewk_view, EINA_FALSE);
> +    elm_object_focus_set(window->search.search_field_count, EINA_FALSE);
> +    elm_object_focus_set(window->search.search_field, EINA_TRUE);

Ditto.

> Tools/MiniBrowser/efl/main.c:1881
> +    elm_object_text_set(window->search.search_field_count, " ");

Is space needed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.