[Webkit-unassigned] [Bug 134508] In needs FTL implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134508


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234203|review?                     |review-
               Flag|                            |




--- Comment #2 from Filip Pizlo <fpizlo at apple.com>  2014-07-02 15:43:19 PST ---
(From update of attachment 234203)
View in context: https://bugs.webkit.org/attachment.cgi?id=234203&action=review

Add a test for the generic In case and change the sizeOfCheckIn.  Otherwise LGTM!

> Source/JavaScriptCore/ftl/FTLInlineCacheSize.cpp:70
> +#if CPU(ARM64)
> +    return 44; // TODO: I DON'T YET KNOW WHAT TO PUT HERE
> +#else
> +    return 32; // TODO: I DON'T YET KNOW WHAT TO PUT HERE 
> +#endif

In general, you should put the smallest value that doesn't result in a crash.  In this case it's just the size of a patchable jump, which on x86 is 5 and on ARM is 4.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.