[Webkit-unassigned] [Bug 134486] [EFL][WK2] Minibrowser: Enhance the application to show text search count

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134486





--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2014-07-02 01:42:40 PST ---
(From update of attachment 234153)
View in context: https://bugs.webkit.org/attachment.cgi?id=234153&action=review

> Tools/ChangeLog:3
> +        [EFL][WK2] Minibrowser: Enhance the application to show text search count

Enhance the Minibrowser to show text search count and close search bar

> Tools/MiniBrowser/efl/main.c:1871
> +    window->search.search_field_count = elm_entry_add(window->elm_window);

Why do you use entry?

IMO, elm_label looks enough.
At least, it should be readonly, right?

> Tools/MiniBrowser/efl/main.c:1882
> +    window->search.close_button = create_toolbar_button(window->elm_window, "close");

Can we locate this button at right most position?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.