[Webkit-unassigned] [Bug 127555] [curl] Add WEB_TIMING support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127555





--- Comment #5 from sipka at inf.u-szeged.hu  2014-01-31 05:30:40 PST ---
(In reply to comment #3)
> (From update of attachment 222106 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222106&action=review
> 
> Looks good, but I had a question about the removal of a "didReceiveResponse" call. Also, you accidentally introduced a blank line.
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:-468
> > -            client->didReceiveResponse(job, d->m_response);
> 
> Why don't we need this call to didReceiveResponse anymore? Does CurlCacheManager do this work as well?
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:657
> > +
> 
> Extra blank line!

Instead of calling didReceiveResponse from the headerCallback function, I call it from downloadTimerCallback (and from dispatchSynchronousJob in synchronous case) to make sure that the webtiming informations will be retrieved and set properly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.