[Webkit-unassigned] [Bug 115643] Document should be constructable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115643


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222642|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2014-01-30 17:22:44 PST ---
(From update of attachment 222642)
View in context: https://bugs.webkit.org/attachment.cgi?id=222642&action=review

> Source/WebCore/dom/Document.h:262
> +        return adoptRef(new Document(0, context.url()));

Please use nullptr instead of 0 here.

I don’t see why context.url() would be correct for this document. I think we need to make a document without a URL here.

DOMImplementation.createDocument also sets the security origin on the document it creates. I suspect we need to do the same here.

I think we need some test coverage that goes beyond “this is a document” and checks these other properties of the document we create.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.