[Webkit-unassigned] [Bug 127842] ConnectionUnix: use F_SETFD to set the FD_CLOEXEC flag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127842


Sergio Correia (qrwteyrutiyoup) <sergio.correia at openbossa.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergio.correia at openbossa.or
                   |                            |g




--- Comment #2 from Sergio Correia (qrwteyrutiyoup) <sergio.correia at openbossa.org>  2014-01-30 16:17:24 PST ---
Nice catch!

After a quick look, SharedMemory::createHandle() 
[WebKit2/Platform/unix/SharedMemoryUnix.cpp] seems suspicious, as in it does
fcntl(duplicatedHandle, F_SETFD, FD_CLOEXEC | accessModeFile(protection)) == -1).
Seems like it should be F_SETFD for FD_CLOEXEC and F_SETFL for the access mode (O_RDONLY or O_RDWR, in this case), no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.