[Webkit-unassigned] [Bug 127876] Extended background should only create margin tiles for pages with background images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127876





--- Comment #10 from Beth Dakin <bdakin at apple.com>  2014-01-30 11:02:23 PST ---
(In reply to comment #7)
> (From update of attachment 222623 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222623&action=review
> 
> > Source/WebCore/rendering/RenderLayerBacking.cpp:244
> > -    int marginSize = extendBackground ? 512 : 0;
> > +    int marginSize = hasExtendedBackgroundRect ? 512 : 0;
> 
> What is the magical 512?  Could you make it a constant with informative name?

Yeah, right now it's just mimicking the tile size, but those static const ints should probably live somewhere more share-able (they are currently in TileController.mm). Any suggestions for a good spot?

static const int defaultTileWidth = 512;
static const int defaultTileHeight = 512;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.