[Webkit-unassigned] [Bug 127555] [curl] Add WEB_TIMING support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 30 10:05:13 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127555





--- Comment #3 from Brent Fulgham <bfulgham at webkit.org>  2014-01-30 10:02:37 PST ---
(From update of attachment 222106)
View in context: https://bugs.webkit.org/attachment.cgi?id=222106&action=review

Looks good, but I had a question about the removal of a "didReceiveResponse" call. Also, you accidentally introduced a blank line.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:-468
> -            client->didReceiveResponse(job, d->m_response);

Why don't we need this call to didReceiveResponse anymore? Does CurlCacheManager do this work as well?

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:657
> +

Extra blank line!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list