[Webkit-unassigned] [Bug 127896] Web Inspector: Implement open/close Console window shortcut

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127896





--- Comment #5 from Diego Pino <dpino at igalia.com>  2014-01-30 08:49:25 PST ---
(From update of attachment 222641)
View in context: https://bugs.webkit.org/attachment.cgi?id=222641&action=review

>>> Source/WebInspectorUI/UserInterface/KeyboardShortcut.js:183
>>> +            result += InspectorFrontendHost.platform() === "mac" ? "\u2325" : "\u2387";
>> 
>> Arn't these the same symbol?
> 
> I guess on Mac they might be, but not on other platforms.

\u2325 is the 'Option' key symbol (http://en.wikipedia.org/wiki/Option_key)
\u2387 is the 'Alternative' key symbol (http://en.wikipedia.org/wiki/Alt_key)

In Mac the 'Option' key (which is also labeled as 'Alt' I think) has always the '\u2325' symbol printed on the key. In no mac keyboards, the equivalent of the 'Option' key is the 'Alt' key, and although it has no symbol printed on it I think it's better to print the correspondent Unicode symbol for the 'Alt' key. As a matter of fact, the first time I checked the shortcuts I could understand the symbols for Shift and Control, but as for the Option or Command key (Mac key) symbols I had to figure out what keys were those.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.